Give read permissions to non-root #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this it's hard to run the exporter as non-root. Also, there is no need to give the executable bit to regular files, the capital `X` should be enough.
|
Hello, thank you for the PR |
porridge
added a commit
to d2iq-archive/kudo-cassandra-operator
that referenced
this pull request
Feb 19, 2020
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)): ``` porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter Unable to find image 'criteord/cassandra_exporter:2.3.2' locally 2.3.2: Pulling from criteord/cassandra_exporter bc51dd8edc1b: Pull complete d1d06863bb82: Pull complete adf4d10a782b: Pull complete 7db4424ff270: Pull complete e008a301333c: Pull complete 10121b885a52: Pull complete 0d34188e8091: Pull complete fc3c7604e1c5: Pull complete 019737f36353: Pull complete a26e5d6f647b: Pull complete 3b6b59aecfbd: Pull complete Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3 Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2 total 4760 -rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar porridge@beczulka:~$ ```
porridge
added a commit
to d2iq-archive/kudo-cassandra-operator
that referenced
this pull request
Feb 21, 2020
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)): ``` porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter Unable to find image 'criteord/cassandra_exporter:2.3.2' locally 2.3.2: Pulling from criteord/cassandra_exporter bc51dd8edc1b: Pull complete d1d06863bb82: Pull complete adf4d10a782b: Pull complete 7db4424ff270: Pull complete e008a301333c: Pull complete 10121b885a52: Pull complete 0d34188e8091: Pull complete fc3c7604e1c5: Pull complete 019737f36353: Pull complete a26e5d6f647b: Pull complete 3b6b59aecfbd: Pull complete Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3 Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2 total 4760 -rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar porridge@beczulka:~$ ```
porridge
added a commit
to d2iq-archive/kudo-cassandra-operator
that referenced
this pull request
Mar 3, 2020
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)): ``` porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter Unable to find image 'criteord/cassandra_exporter:2.3.2' locally 2.3.2: Pulling from criteord/cassandra_exporter bc51dd8edc1b: Pull complete d1d06863bb82: Pull complete adf4d10a782b: Pull complete 7db4424ff270: Pull complete e008a301333c: Pull complete 10121b885a52: Pull complete 0d34188e8091: Pull complete fc3c7604e1c5: Pull complete 019737f36353: Pull complete a26e5d6f647b: Pull complete 3b6b59aecfbd: Pull complete Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3 Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2 total 4760 -rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar porridge@beczulka:~$ ``` We actually bump to 2.3.3 since the earlier one was non-functional.
porridge
added a commit
to d2iq-archive/kudo-cassandra-operator
that referenced
this pull request
Mar 3, 2020
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)): ``` porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter Unable to find image 'criteord/cassandra_exporter:2.3.2' locally 2.3.2: Pulling from criteord/cassandra_exporter bc51dd8edc1b: Pull complete d1d06863bb82: Pull complete adf4d10a782b: Pull complete 7db4424ff270: Pull complete e008a301333c: Pull complete 10121b885a52: Pull complete 0d34188e8091: Pull complete fc3c7604e1c5: Pull complete 019737f36353: Pull complete a26e5d6f647b: Pull complete 3b6b59aecfbd: Pull complete Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3 Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2 total 4760 -rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar porridge@beczulka:~$ ``` We actually bump to 2.3.3 since the earlier one was non-functional. Also rename a parameter in cassandra config as the old one is not recognized.
porridge
added a commit
to d2iq-archive/kudo-cassandra-operator
that referenced
this pull request
Mar 3, 2020
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)): ``` porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter Unable to find image 'criteord/cassandra_exporter:2.3.2' locally 2.3.2: Pulling from criteord/cassandra_exporter bc51dd8edc1b: Pull complete d1d06863bb82: Pull complete adf4d10a782b: Pull complete 7db4424ff270: Pull complete e008a301333c: Pull complete 10121b885a52: Pull complete 0d34188e8091: Pull complete fc3c7604e1c5: Pull complete 019737f36353: Pull complete a26e5d6f647b: Pull complete 3b6b59aecfbd: Pull complete Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3 Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2 total 4760 -rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar porridge@beczulka:~$ ``` We actually bump to 2.3.3 since the earlier one was non-functional. Also rename a parameter in cassandra config as the old one is not recognized.
porridge
added a commit
to d2iq-archive/kudo-cassandra-operator
that referenced
this pull request
Mar 4, 2020
The permissions are now [fixed](criteo/cassandra_exporter#68) in upstream repo, so we can drop [the chown](#4 (review)): ``` porridge@beczulka:~$ docker run criteord/cassandra_exporter:2.3.2 ls -l /opt/cassandra_exporter Unable to find image 'criteord/cassandra_exporter:2.3.2' locally 2.3.2: Pulling from criteord/cassandra_exporter bc51dd8edc1b: Pull complete d1d06863bb82: Pull complete adf4d10a782b: Pull complete 7db4424ff270: Pull complete e008a301333c: Pull complete 10121b885a52: Pull complete 0d34188e8091: Pull complete fc3c7604e1c5: Pull complete 019737f36353: Pull complete a26e5d6f647b: Pull complete 3b6b59aecfbd: Pull complete Digest: sha256:9fe7cfef9b03ca294c80e5da098add4698c4103bbddf382dd93d2e01a073d6e3 Status: Downloaded newer image for criteord/cassandra_exporter:2.3.2 total 4760 -rw-rw-r-- 1 root root 4871483 Feb 10 13:31 cassandra_exporter.jar porridge@beczulka:~$ ``` We actually bump to 2.3.4 since there were other problems with 2.3.2 and 2.3.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this it's hard to run the exporter as non-root.
Also, there is no need to give the executable bit to regular files, the capital
Xshould be enough.